Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run all steps in a container #44969

Merged
merged 5 commits into from
Dec 12, 2024
Merged

Run all steps in a container #44969

merged 5 commits into from
Dec 12, 2024

Conversation

ellahathaway
Copy link
Member

@ellahathaway ellahathaway commented Nov 19, 2024

Fixes dotnet/source-build#4547

SB pipeline run (internal Microsoft link)
UB pipeline run (internal Microsoft link)

I ran the SB pipeline multiple times, and I did not encounter the issue described in dotnet/source-build#3233. Given this, I feel comfortable removing the fix added in dotnet/installer#15488 in order to workaround dotnet/source-build#4796.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Nov 19, 2024
@ellahathaway
Copy link
Member Author

/azp run sdk-unified-build-full

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ellahathaway
Copy link
Member Author

Source-build isn't running all steps in containers: https://dev.azure.com/dnceng/internal/_build/results?buildId=2585278&view=results

The legs don't run the "initialize containers" step, so I'm working to determine why. This doesn't happen in PR checks.

@MichaelSimons
Copy link
Member

/azp run dotnet-source-build-lite

Copy link

No pipelines are associated with this pull request.

@ellahathaway
Copy link
Member Author

Source-build isn't running all steps in containers: https://dev.azure.com/dnceng/internal/_build/results?buildId=2585278&view=results

The legs don't run the "initialize containers" step, so I'm working to determine why. This doesn't happen in PR checks.

This is because the internal pipelines use 1ES PTs. I'm adjusting the templates so that the containers work in with these yamls.

@ellahathaway
Copy link
Member Author

Internal SB pipeline run

@ellahathaway
Copy link
Member Author

New SB pipeline run. The alpine leg times out because the build never runs. It's possible that this is related to the container not being a nonglibc-based container, but SDK has a containerized job that uses the alpine 319 with node image, and that job runs just fine.

@ellahathaway
Copy link
Member Author

/azp run sdk-unified-build-full

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ellahathaway
Copy link
Member Author

/azp run sdk-unified-build-full

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ellahathaway
Copy link
Member Author

/azp run sdk-unified-build-full

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ellahathaway ellahathaway marked this pull request as ready for review December 12, 2024 00:13
@ellahathaway ellahathaway requested review from a team as code owners December 12, 2024 00:13
src/SourceBuild/content/build.sh Outdated Show resolved Hide resolved
@ViktorHofer ViktorHofer enabled auto-merge (squash) December 12, 2024 08:26
akoeplinger added a commit that referenced this pull request Dec 16, 2024
It doesn't work on macOS because the option only exists in GNU cp.

Follow-up to #44969
@ellahathaway ellahathaway deleted the containers branch December 16, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run all VMR CI steps in containers
5 participants