-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run all steps in a container #44969
Run all steps in a container #44969
Conversation
/azp run sdk-unified-build-full |
Azure Pipelines successfully started running 1 pipeline(s). |
Source-build isn't running all steps in containers: https://dev.azure.com/dnceng/internal/_build/results?buildId=2585278&view=results The legs don't run the "initialize containers" step, so I'm working to determine why. This doesn't happen in PR checks. |
/azp run dotnet-source-build-lite |
No pipelines are associated with this pull request. |
This is because the internal pipelines use 1ES PTs. I'm adjusting the templates so that the containers work in with these yamls. |
7dc211a
to
76a4881
Compare
New SB pipeline run. The alpine leg times out because the build never runs. It's possible that this is related to the container not being a nonglibc-based container, but SDK has a containerized job that uses the alpine 319 with node image, and that job runs just fine. |
/azp run sdk-unified-build-full |
Azure Pipelines successfully started running 1 pipeline(s). |
d0da107
to
fd1b985
Compare
/azp run sdk-unified-build-full |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run sdk-unified-build-full |
Azure Pipelines successfully started running 1 pipeline(s). |
It doesn't work on macOS because the option only exists in GNU cp. Follow-up to #44969
Fixes dotnet/source-build#4547
SB pipeline run (internal Microsoft link)
UB pipeline run (internal Microsoft link)
I ran the SB pipeline multiple times, and I did not encounter the issue described in dotnet/source-build#3233. Given this, I feel comfortable removing the fix added in dotnet/installer#15488 in order to workaround dotnet/source-build#4796.